InnerTxnBuilder Second transaction is not stored in the blockchain

scholtz · February 6, 2023, 11:49pm

Hi guys,

anybody can take a look on what i am doing wrong?

Only one transaction is always written as inner transaction when i do the app call…

When i put line 87 before, i get the opt in for the fee account, and if i have the first the transferASABase i get the opt in for the application.

The wierd thing is that the app call succeed but has only one inner appcall.

github.com

scholtz/stabilitas-apps/blob/f420ebbc47b14490aa8982a16f26bb25179b8e4a/onchain/contracts/reserve/publicMethods/configure.py#L86


      
                  zero.set(Int(0)),
                  emptyStr.set(Bytes("")),
                  receiver.set(addrFee.address()),
                  receiverApp.set(Global.current_application_address()),
                  # amount: abi.Uint64, 
                  # sender: abi.Address,
                  # receiver: abi.Address,
                  # asset: abi.Asset, 
                  # note: abi.String, 
                  
                  transfers.transferASABase(zero,receiverApp,assetOracleBase,emptyStr),
                  transfers.transferASA(zero,addrFee,receiver,assetOracleBase,emptyStr), # opt in to usdc to receive fees
                  #transfers.transferASA(zero,addrLPFee,addrLPFee,assetOracleBase,emptyStr), # opt in to usdc to receive lp fees
                  #transfers.transferASA(zero,addrLPFee,addrLPFee,assetAMMLP,emptyStr),# opt in to lp asset to receive lp position
                  Approve()
              )
          
          

          
# c_global_app_oracle_ecb = Bytes("o1")
          # c_global_app_oracle_amm1w = Bytes("o2")
          # c_global_app_oracle_amm1h = Bytes("o3")

There is nothing special in those methods… stabilitas-apps/transfers.py at f420ebbc47b14490aa8982a16f26bb25179b8e4a · scholtz/stabilitas-apps · GitHub

github.com

scholtz/stabilitas-apps/blob/f420ebbc47b14490aa8982a16f26bb25179b8e4a/onchain/contracts/reserve/privateMethods/transfers.py#L163


      
                  TxnField.asset_receiver: receiver.get(),
                  TxnField.xfer_asset: asset.asset_id(),
                  TxnField.note: note.get(),
                  TxnField.fee : Int(0),
                }),
                InnerTxnBuilder.Submit(),
                Approve(),
              )
              
          @Subroutine(TealType.none)
          def transferASA(
              amount: abi.Uint64, 
              sender: abi.Account,
              receiver: abi.Address,
              asset: abi.Asset, 
              note: abi.String, 
          ) -> Expr:
              return Seq(
                InnerTxnBuilder.Begin(),
                InnerTxnBuilder.SetFields({
                  TxnField.type_enum: TxnType.AssetTransfer,

fabrice · February 7, 2023, 2:13am

The Approve there stabilitas-apps/transfers.py at f420ebbc47b14490aa8982a16f26bb25179b8e4a · scholtz/stabilitas-apps · GitHub immediately exits the full TEAL program.

Instead, you want to use Return that returns just from the subroutine.

I made a PR to clarify this point: Clarify that `Approve` and `Reject` always exit by fabrice102 · Pull Request #660 · algorand/pyteal · GitHub